Skip to content

docs: fix broken links in guides/choosing-a-test-runner (fix #805) #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2018

Conversation

moraveyo
Copy link
Contributor

@moraveyo moraveyo commented Jul 4, 2018

No description provided.

@38elements
Copy link
Contributor

38elements commented Jul 5, 2018

It seems that the links work normally now.
Would you tell me why this change is necessary?
https://vue-test-utils.vuejs.org/guides/choosing-a-test-runner.html#testing-single-file-components

@moraveyo moraveyo changed the title docs: fix broken links in guides/choosing-a-test-runner docs: fix broken links in guides/choosing-a-test-runner (fix #805) Jul 5, 2018
@moraveyo
Copy link
Contributor Author

moraveyo commented Jul 5, 2018

Doesn't open in new tab - got 404. I filed an issue #805

@moraveyo
Copy link
Contributor Author

moraveyo commented Jul 5, 2018

These links open not really as I expect In the same window too. In fact, these are the sections of the same document: look at the navigation, and after all you can simply scroll down to them.

But when you click at the link - it opens as separate document.
A little confusing.

@moraveyo
Copy link
Contributor Author

moraveyo commented Jul 5, 2018

Some research.

When you just click the link, it opens with url:https://vue-test-utils.vuejs.org/guides/testing-SFCs-with-jest.html (see the upper case!) - the Vue works it out fine.

When you open it in new tab/window - the page first blinks like something is there, and then it's 404. And the url is all lowercase.

So maybe it's some deeper problem in Vue itself, I'm not so deep in it.

@moraveyo
Copy link
Contributor Author

moraveyo commented Jul 5, 2018

Should have written it in the issue... I'll copy there.

@eddyerburgh
Copy link
Member

Thanks for this @moraveyo . Does the URL change solve your issue?

@moraveyo
Copy link
Contributor Author

moraveyo commented Jul 24, 2018

Yes, it does.

@eddyerburgh eddyerburgh merged commit 172310c into vuejs:dev Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants